substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Update Template README

Open nuke-web3 opened this issue 3 years ago β€’ 8 comments

  • remove matrix links
  • remove playground references (service reported as sun-setting)
  • OSPL rule per Docs style guide

nuke-web3 avatar Nov 19 '22 20:11 nuke-web3

cargo doesn't have anything that touches .md files - so no it will not be formatted otherwise AFAIK

nuke-web3 avatar Nov 23 '22 18:11 nuke-web3

@sacha-l @lisa-parity @al3mart @jeluard - this should be ready now for review & merge, so we can act on https://github.com/substrate-developer-hub/substrate-node-template/issues/396

nuke-web3 avatar Dec 12 '22 01:12 nuke-web3

Thank you very much @lisa-parity for the suggestions! :star_struck: Merged them in now. I think we are OK to merge, please approve?

nuke-web3 avatar Dec 12 '22 21:12 nuke-web3

Should work for you now (if you try again by undoing the chmod +x). Can you check @ltfschoen ? πŸ™πŸ»

sacha-l avatar Jan 16 '23 16:01 sacha-l

bot rebase

ggwpez avatar Jan 16 '23 23:01 ggwpez

Rebased

Should work for you now (if you try again by undoing the chmod +x).

There is a more substantial fix for the docker stuff here https://github.com/paritytech/substrate/pull/13039 anyway, so should be good for now.

ggwpez avatar Jan 16 '23 23:01 ggwpez

Should work for you now (if you try again by undoing the chmod +x). Can you check @ltfschoen ? πŸ™πŸ»

yes it works now when i run the script after a fresh clone and when i have the docker-compose binary (with dash symbol) is installed

ltfschoen avatar Jan 18 '23 23:01 ltfschoen

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 18 '23 04:02 stale[bot]

bot rebase

nuke-web3 avatar Feb 18 '23 11:02 nuke-web3

Rebased

@sacha-l @jeluard - review and approve?

@ltfschoen Β #13039Β can come later, and thus is ok by you? Please approve

nuke-web3 avatar Feb 18 '23 11:02 nuke-web3

bot merge

nuke-web3 avatar Feb 21 '23 14:02 nuke-web3

Error: Statuses failed for 60038cc9d31594eb1363e65132e9a9016c87a117

bot merge

nuke-web3 avatar Feb 21 '23 19:02 nuke-web3

Error: Statuses failed for 60038cc9d31594eb1363e65132e9a9016c87a117

bot rebase

nuke-web3 avatar Feb 21 '23 19:02 nuke-web3

Rebased

bot merge

ggwpez avatar Feb 21 '23 22:02 ggwpez