Warn validators with slow hardware

[Szegoo]

Closes: #12017

TODO:

• [x] Move Metric to sc-sysinfo
• [x] Move Requirement(s) to sc-sysinfo
• [x] Compare the benchmark results inside sc-sysinfo to requirements.

polkadot companion: https://github.com/paritytech/polkadot/pull/6269 cumulus companion: https://github.com/paritytech/cumulus/pull/1863

Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

[Szegoo]

@ggwpez PTAL.

[ordian]

Looking at the #12017, my understanding of it is to change the log level to a warn if the benchmark is slow and --validator flag is passed, not enable hw bench unconditionally when --validator is enabled.

[Szegoo]

Moving this back to draft since there is still some work that needs to be done on this PR before it is ready for review.

[Szegoo]

@ordian Could you take another look now that I have updated the code?

[ordian]

Looks good to me in effect, but I'll let the substrate team judge whether moving the types to sysinfo is OK. Thanks!

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[Szegoo]

Bump

[Szegoo]

@ggwpez @koute Did you manage to think of a better approach so that there is less repetition or is it ok like this?

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[Szegoo]

@ggwpez I have tested this to try if this actually works by running:

./target/release/substrate --chain=local --validator

I have set one of the requirements too high so that I can see if I will get a warning when not passing. I did get the warning but if I am being honest I would never actually notice it :P(I initially thought it wasn't working because it just blends into the rest of the logs.). Maybe using some ⚠️ emoji would help?

[ggwpez]

Maybe using some :warning: emoji would help?

Yea good idea. Some :warning: :warning: :warning: could help.

[Szegoo]

@ggwpez I have added warning emojis to the log. Could you approve the PR if the changes are fine?

[ggwpez]

@ggwpez I have added warning emojis to the log. Could you approve the PR if the changes are fine?

Yea sorry for the slow responses here, am really busy right now.

[Szegoo]

Please put your address for a tip.

I have added my address, Thanks!

[ggwpez]

The companion checks are still red. Dont know why it says its un-mergable, but i can also not build Polkadot with it locally.

[Szegoo]

Should still figure out those companion/polkadot issues mentioned above though

@sam0x17 It should probably work now. I don't have permission to rerun the CI so it would be good if you could do that.

[sam0x17]

re-running cumulus now :)

[Szegoo]

Hmm, it is weird that it still doesn't pass the CI check. For some reason, the cumulus PR doesn't see the changes made in the Polkadot PR. I tough putting polkadot companion: https://github.com/paritytech/polkadot/pull/6269 into the Cumulus PR description would fix this.

[ggwpez]

I dont get it either. Looks correct.

[bkchr]

/tip small

[substrate-tip-bot[bot]]

@bkchr ERROR: Error: Unable to match provided value to a secret URI Error: Unable to match provided value to a secret URI at keyExtractSuri (/usr/src/app/node_modules/@polkadot/util-crypto/cjs/key/extractSuri.js:22:11) at Keyring.createFromUri (/usr/src/app/node_modules/@polkadot/keyring/cjs/keyring.js:265:40) at Keyring.addFromUri (/usr/src/app/node_modules/@polkadot/keyring/cjs/keyring.js:192:30) at getContributorMetadata (/usr/src/app/dist/tip.js:1:2834) at runMicrotasks () at processTicksAndRejections (node:internal/process/task_queues:96:5) at async tipUser (/usr/src/app/dist/tip.js:1:1753) at async onIssueComment (/usr/src/app/dist/bot.js:1:1396)

[mordamax]

/tip small

[substrate-tip-bot[bot]]

@mordamax You are not allowed to request a tip. Only members of paritytech/tip-bot-approvers are allowed.

[bkchr]

/tip small

[substrate-tip-bot[bot]]

@bkchr ERROR: Error: Unable to match provided value to a secret URI Error: Unable to match provided value to a secret URI at keyExtractSuri (/usr/src/app/node_modules/@polkadot/util-crypto/cjs/key/extractSuri.js:22:11) at Keyring.createFromUri (/usr/src/app/node_modules/@polkadot/keyring/cjs/keyring.js:265:40) at Keyring.addFromUri (/usr/src/app/node_modules/@polkadot/keyring/cjs/keyring.js:192:30) at getContributorMetadata (/usr/src/app/dist/tip.js:1:2834) at runMicrotasks () at processTicksAndRejections (node:internal/process/task_queues:96:5) at async tipUser (/usr/src/app/dist/tip.js:1:1753) at async onIssueComment (/usr/src/app/dist/bot.js:1:1396)

[mordamax]

/tip small

[substrate-tip-bot[bot]]

@mordamax A small tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips