Abstracts elections-phragmen pallet to use NposSolver

[gpestana]

This PR refactors the current elections-phragmen pallet to use an NposSolver instead of hardcoding one flavor of phragmen.

To-do:

• [x] rename elections-phragmen to elections-generic
• [x] change name of the pallet's dir from elections-phragmen to elections
• [x] comments on changing the name of the pallet (but not the lockid)
• [ ] try with follow-chain on a block that performs a council election

polkadot companion: https://github.com/paritytech/polkadot/pull/6278

Closes https://github.com/paritytech/substrate/issues/8250 Follow up of https://github.com/paritytech/substrate/pull/12563

[kianenigma]

I think we should rename the pallet as well fwiw.

[gpestana]

I think we should rename the pallet as well fwiw.

Yes, was leaving that to the end. renaming now

[gpestana]

bot rebase

[gpestana]

/cmd queue -c bench-bot $ pallet dev pallet_elections

[gpestana]

bot rebase

[gpestana]

/cmd queue -c bench-bot $ pallet dev pallet_elections

[kianenigma]

needs rebase + ~~would be good to re-weight the election pallet with the bot.~~

[kianenigma]

/cmd queue -c bench-bot $ pallet dev pallet_elections

[gpestana]

/cmd queue -c bench-bot $ pallet dev pallet_elections

[gpestana]

bot rebase

[gpestana]

/cmd queue -c bench-bot $ pallet dev pallet_elections

[gpestana]

bot rebase

[gpestana]

/cmd queue -c bench-bot $ pallet dev pallet_election_provider_support

[gpestana]

bot rebase

[rossbulat]

bot bench $ pallet dev pallet_election_provider_support_benchmarking

[gpestana]

bot bench $ pallet dev pallet_election_provider_support

[gpestana]

bot clean

[gpestana]

bot bench $ pallet dev pallet_election_provider_support_benchmarking

[command-bot[bot]]

@gpestana https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2414803 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_election_provider_support_benchmarking. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-94637b6e-48b1-45b4-8ea6-ac3345937e08 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot[bot]]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_election_provider_support_benchmarking has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2414803 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2414803/artifacts/download.

[kianenigma]

Would be good to see a bit more context about upgrade choices in the PR description:

1. One should not rename the pallet in construct_runtime, or else use move_pallet (not reocmmended)
2. One should consider switching to a simpler Solver type like approval-voting.

[gpestana]

Would be good to see a bit more context about upgrade choices in the PR description:

1. One should not rename the pallet in construct_runtime, or else use move_pallet (not reocmmended)
2. One should consider switching to a simpler Solver type like approval-voting.

Good points, added to the PR comments.

[gpestana]

bot rebase

[paritytech-processbot[bot]]

Rebased

[gpestana]

bot rebase

[paritytech-processbot[bot]]

Branch is already up-to-date

[gpestana]

bot merge

[paritytech-processbot[bot]]

Error: Github API says https://github.com/paritytech/polkadot/pull/6278 is not mergeable

[gpestana]

bot merge

[Polkadot-Forum]

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/mis-configuring-pallet-elections-phragmen/2502/1