Dont Re-export sp-arithmetic from sp-runtime

[MrishoLukamba]

Fixes #12040 Polkadot address: 133WyzJ4cEEbQ4twhT3nQpoXYeTCzeKn8kWfRfEi4XDF7wKh The Pr is not complete as this changes alots of pallets because sp-arithmetic affects alots of them. So the changes will be made as small as possible untill all dependencies from arithmetic re-exported from sp runtime is not re-exported anymore.

[MrishoLukamba]

All done, Please review @ggwpez @kianenigma @acatangiu @andresilva

[MrishoLukamba]

Next time please put some more effort into this. Especially when you ping a lot of people.

Okey

[bkchr]

@MrishoLukamba the CI is still failing.

[MrishoLukamba]

@MrishoLukamba the CI is still failing.

What can be the reason because it is compiling

[ggwpez]

@MrishoLukamba you can click on the failing CI jobs and see why.
Eg https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1960850:

error[E0432]: unresolved imports `sp_runtime::Perbill`, `sp_runtime::Percent`
   --> primitives/npos-elections/src/phragmms.rs:235:19
    |
235 |     use sp_runtime::{Perbill, Percent};
    |                      ^^^^^^^  ^^^^^^^ no `Percent` in the root
    |                      |
    |                      no `Perbill` in the root

[shawntabrizi]

you also need to call cargo +nightly fmt

[MrishoLukamba]

you also need to call cargo +nightly fmt

Updating the docs also

[MrishoLukamba]

** Assign reviewers / pr-custom-review (pull_request) ** Successful in 11s Required

Now the CI complains but when I check the job its okey and everything is fine.

[ggwpez]

Now the CI complains but when I check the job its okey and everything is fine.

CI is still red. You click on "Details" and then on the pipeline and on its failing job, eg https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1971086

[MrishoLukamba]

the CI which are failing now its not because of the codebase anymore. So its done and thanks @shawntabrizi

[shawntabrizi]

@MrishoLukamba unfortunately... you now need to repeat this process for Polkadot and Cumulus for us to merge this PR

See: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#updating-polkadot-as-well

[MrishoLukamba]

Okey

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[bkchr]

Ping @MrishoLukamba

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[juangirini]

/tip medium

[substrate-tip-bot[bot]]

@juangirini You are not allowed to request a tip. Only members of paritytech/tip-bot-approvers are allowed.

[juangirini]

/tip medium

[substrate-tip-bot[bot]]

@juangirini A medium tip was successfully submitted for MrishoLukamba (133WyzJ4cEEbQ4twhT3nQpoXYeTCzeKn8kWfRfEi4XDF7wKh on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

[juangirini]

@MrishoLukamba FYI #12040 has been closed so your PR is not going to be merged, though we appreciate your contribution. Thanks!