substrate registrar: Avoid freebies in provide

registrar: Avoid freebies in provide_judgement

Open dharjeezy opened this issue 2 years ago • 4 comments

This PR evaluates the error being returned by repatriate_reserved

Wrote test

Fixed Benchmarks

closes #12460

Polkadot address: 12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku

Oct 10 '22 20:10 dharjeezy

@dharjeezy please fix the tests and please also add a specific test for exactly the fixed case.

Oct 10 '22 21:10 bkchr

@dharjeezy please fix the tests and please also add a specific test for exactly the fixed case.

Oh...Alright, Will do.

Oct 10 '22 21:10 dharjeezy

@bkchr @kianenigma

Wrote test and fixed benchmarks

Oct 15 '22 00:10 dharjeezy

Generally looking good. We will just need to wait for the audit, but this should be simple.

Please also provide your polkadot address

I have gone ahead to update my PR description with my Polkadot address @bkchr

Oct 16 '22 20:10 dharjeezy

bot merge

Oct 19 '22 12:10 bkchr

Waiting for commit status.

Oct 19 '22 12:10 paritytech-processbot[bot]

/tip small

Oct 19 '22 12:10 bkchr

@bkchr A small tip was successfully submitted for dharjeezy (12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

Oct 19 '22 12:10 substrate-tip-bot[bot]