substrate icon indicating copy to clipboard operation
substrate copied to clipboard

frame-support-test: migrate tests from `decl_*` macros to the new `pallet` macros

Open koushiro opened this issue 2 years ago • 2 comments

What does it do?

This PR is a part of #12248 and it need #12401 to be merged firstly

In this PR, I migrate the tests of frame/support/test from old decl_* macros to the new pallet attribute macros, and remove some useless tests.

After this, I will remove the decl_* macros and do some other trivial things.

koushiro avatar Oct 07 '22 13:10 koushiro

Maybe I should use frame-system directly as base config to replace frame-support-test pallet and system module? What do you think?

By now, I removed the system module and used frame-system-test pallet as base config.

koushiro avatar Oct 08 '22 07:10 koushiro

@kianenigma I think #12401 could be reviewed and merged firstly?

koushiro avatar Oct 11 '22 08:10 koushiro

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 17 '22 01:11 stale[bot]

bot rebase

ggwpez avatar Apr 29 '23 15:04 ggwpez

Rebased

bot rebase

ggwpez avatar May 02 '23 16:05 ggwpez

Rebased

bot merge

ggwpez avatar May 09 '23 09:05 ggwpez

/tip large

(combined tip together for https://github.com/paritytech/substrate/pull/12401, therefore large)

ggwpez avatar May 09 '23 10:05 ggwpez

@ggwpez Contributor did not properly post their account address.

Make sure the pull request description has: "{network} address: {address}".

substrate-tip-bot[bot] avatar May 09 '23 10:05 substrate-tip-bot[bot]

showerthought: would be cool if they could just specify it in their github bio 🤔

sam0x17 avatar May 09 '23 15:05 sam0x17