substrate icon indicating copy to clipboard operation
substrate copied to clipboard

[Enhancement] Convert fast-unstake to use StakingInterface, decouplin…

Open ruseinov opened this issue 3 years ago • 5 comments

Resolves https://github.com/paritytech/substrate/issues/12337 or rather what's left of it. As we decided not to support pool joins at the moment we can probably ignore that requirement?

ruseinov avatar Oct 05 '22 13:10 ruseinov

bot rebase

ruseinov avatar Oct 11 '22 15:10 ruseinov

Rebased

@kianenigma this needs your attention now. I've done fixes to nomination-pools and fast-unstake, only the tests/benches are failing now, but I'd like to verify the approach first.

ruseinov avatar Oct 13 '22 08:10 ruseinov

bot rebase

ruseinov avatar Oct 18 '22 09:10 ruseinov

Rebased

@kianenigma I have addressed all the comments except for halt and the controller stuff.

I think this is outside of the scope of this PR (halt - because it's already implemented in another one, controller - because it's already released in the original version of fast-unstake, so it has little to do with the work we are doing here).

Let me know if this makes sense.

ruseinov avatar Oct 25 '22 13:10 ruseinov

bot rebase

ruseinov avatar Oct 26 '22 09:10 ruseinov

Rebased

renamed a few trivial things, LGTM otherwise.

kianenigma avatar Oct 27 '22 06:10 kianenigma

bot merge

ruseinov avatar Oct 27 '22 11:10 ruseinov

Error: "Check reviews" status is not passing for https://github.com/paritytech/polkadot/pull/6199

bot merge

ruseinov avatar Oct 29 '22 09:10 ruseinov