substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

Deprecate `decl_*` macros

Open koushiro opened this issue 1 year ago • 1 comments

Close #12248

koushiro avatar Sep 22 '22 09:09 koushiro

@bkchr @KiChjang @kianenigma PTAL

koushiro avatar Sep 22 '22 12:09 koushiro

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

KiChjang avatar Sep 23 '22 08:09 KiChjang

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

I have no particular preference for deleting or deprecating decl_* macros, and both are fine for me.

But I don't know what other people think, whether the macros need to deprecated firstly, and then remove it in a later version ?

koushiro avatar Sep 23 '22 08:09 koushiro

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

We can open a forum thread in Polkadot forum and make some poll. I don't know if someone is may still using them.

bkchr avatar Sep 23 '22 12:09 bkchr

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

shawntabrizi avatar Sep 24 '22 05:09 shawntabrizi

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

Okay, I will open another PR to remove it.

koushiro avatar Sep 27 '22 06:09 koushiro

Seems like we will see a new PR, so I will close this one. Please reopen if otherwise.

kianenigma avatar Sep 30 '22 15:09 kianenigma