substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Move transactions protocol to its own crate

Open altonen opened this issue 3 years ago • 1 comments

Move transactions protocol to its own crate.

polkadot companion: https://github.com/paritytech/polkadot/pull/5973 cumulus companion: https://github.com/paritytech/cumulus/pull/1661

altonen avatar Sep 14 '22 10:09 altonen

This PR supersedes the previous #12198 as the history in that PR was messed up and fixing it would require force-pushing

altonen avatar Sep 14 '22 11:09 altonen

bot merge

acatangiu avatar Sep 26 '22 10:09 acatangiu

Error: Github API says https://github.com/paritytech/polkadot/pull/5973 is not mergeable

bot rebase

acatangiu avatar Sep 26 '22 11:09 acatangiu

Branch is already up-to-date

bot merge

acatangiu avatar Sep 26 '22 12:09 acatangiu

after doing "bot merge" PR updated showing recently added "A1-onice" label; alas bot has already merged it...

@altonen why is this not ready for merge?

acatangiu avatar Sep 26 '22 12:09 acatangiu

I wanted to double-check one thing but I guess it's OK. I don't understand why the Polkadot PR didn't merge and if somebody knows how to fix it, I'd appreciate help

altonen avatar Sep 26 '22 12:09 altonen

I think extra commit went into it after the CI had originally run the companion, just a guess.

We'll see if bot wants to merge once CI goes green, the lockfile was updated correctly.

acatangiu avatar Sep 26 '22 12:09 acatangiu