substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

EPM: allow duplicate submissions

Open kianenigma opened this issue 1 year ago • 2 comments

fixes https://github.com/paritytech/substrate/issues/12228

  • [x] Live testing by @niklasad1
  • [x] Migration

polkadot companion: https://github.com/paritytech/polkadot/pull/6115

As a follow-up, I think we can also remove all of these overlays as they complicate a lot of things..

kianenigma avatar Sep 12 '22 08:09 kianenigma

The CI pipeline was cancelled due to failure one of the required jobs. The job name - cargo-check-benches The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1922078

paritytech-cicd-pr avatar Oct 06 '22 07:10 paritytech-cicd-pr

Not sure about the PoV impact this has, since you now always load all submissions. Depends on how many there usually are i guess…

I still don't read all submissions -- In the past, we read all of theirs scores as a BTreeMap, now we read the same data stored as a Vec<_>. The individual submissions should still be read at most one by one.

kianenigma avatar Oct 13 '22 12:10 kianenigma

bot merge

kianenigma avatar Oct 19 '22 19:10 kianenigma

Error: "Check reviews" status is not passing for https://github.com/paritytech/polkadot/pull/6115

paritytech-processbot[bot] avatar Oct 19 '22 19:10 paritytech-processbot[bot]

bot merge

kianenigma avatar Oct 19 '22 20:10 kianenigma