substrate
substrate copied to clipboard
paritytech
Don't re-export `sp-arithmetic` from `sp-runtime`
Currently, we are re-exporting this crate from sp-runtime. This makes it be a part of a lot of other crates, since sp-runtime is itself a wildly used crate. Consequently, this has prevented us from adding other 3rd party dependencies to sp-arithmetic, since it would naturally leak into the wider sp-runtime as well (https://github.com/encointer/substrate-fixed).
because of this, and the spirit of dependency isolation, we should explicitly import sp-arithmetic when needed, and remove the re-export from sp-runtime.
This will be a big PR, but should be very easy to do.
Could I get some insight on what would need to be done if I take up this issue? I don't mind it taking time, could work on it for a stretch of time.
@MrishoLukamba any news on this issue? This blocks #12153 and we'd be happy to contribute if you no longer work on it
am working . I was off due to personal reasons. Wont take long , due today
As context: we revised and realized that this is too big of a breaking change for too little advantage.
Instead we will aim to not introduce new re-exports instead.
@juangirini it appears there something wrong with editing my response to https://github.com/paritytech/substrate/pull/13863#issuecomment-1539964620
(i.e "can't comment at this time")
I tried to raise the issue of OpenGov support in tip-bot is still WIP...please give some time while I rectify it and update accordingly.
