substrate Removing without_storage_info from scored-pool pallet.

Removing without_storage_info from scored-pool pallet.

Open hbulgarini opened this issue 3 years ago • 3 comments

Removing macro #[pallet::without_storage_info] for scored-pool pallet.

Aug 09 '22 07:08 hbulgarini

bot rebase

CI fails, lets see if a rebase fixes it.

Aug 09 '22 10:08 ggwpez

Rebased

Aug 09 '22 10:08 paritytech-processbot[bot]

Just some comments 👍 PS: I dont see where this is deployed, so adding the notlive label.

Me neither actually. I might include the pallet in the bin/node/runtime/src/lib.rs runtime, but i'm not sure if that makes sense.

Aug 09 '22 12:08 hbulgarini

@ggwpez comments addressed. Please feel free to let me know for any other needed action.

Aug 12 '22 14:08 hbulgarini

@ggwpez i have addressed the rest of the feedback but i see some of the build jobs still failing. Maybe restarting the pipeline?

Aug 15 '22 18:08 hbulgarini

@kianenigma can you confirm that this is not live and we do not need audit?

Aug 15 '22 19:08 ggwpez

@ggwpez i think all the feedback was addressed already.

Sep 08 '22 10:09 hbulgarini

Yea looks like it is good to merge. Just need to resolve one conflict :+1:

Sep 08 '22 11:09 ggwpez

Yea looks like it is good to merge. Just need to resolve one conflict 👍

@ggwpez solved and all check/build process is in green.

Sep 08 '22 15:09 hbulgarini

bot merge

Sep 08 '22 15:09 ggwpez