paritytech
BREAKING: Rename Outer Enums
I have renamed the associated type to RuntimeEvent, also I have renamed the Events inside pallets to PalletEvent. I need to figure out why this is failing some CI checks(it seems like an error is not getting thrown when it should), but other than that I am probably finished with renaming the events. It would be now helpful to check if what I did is correct before I start renaming the Call enum.
CC: @KiChjang @kianenigma
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741073
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741074
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741072
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741113
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741149
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741185
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741221
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741265
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741301
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1741372
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1742832
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1742871
The CI pipeline was cancelled due to failure one of the required jobs. The job name - test-linux-stable The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748815
Looks really good! this is only refactoring the Event, right?
We need
RuntimeCallandRutnimeOriginas well. Should we do those separately or here?
Yes, this is only refactoring the Event for now. I will probably rename RuntimeCall and RuntimeOrigin in this PR.
@kianenigma @KiChjang I believe that I am done with renaming the Events here. Maybe it would be better to make a separate PR for each rename, so could you please review this? I will look into resolving the errors in the companions.
Since the diff size is now smaller I will rename Call and Origin here as well.
@KiChjang @kianenigma I renamed the Call enum to RuntimeCall, could you please take a look?
Please ask in the MR directly instead of opening SE questions in the future, thanks.
For posterity: it was a flaky test.
Please ask in the MR directly instead of opening SE questions in the future, thanks. For posterity: it was a flaky test.
Yeah, it is resolved now, I deleted the question.
@Szegoo your Polkadot address please, a tip is coming.
I have added my address, thanks!
@kianenigma Could you rerun thegitlab-check-dependent-polkadot CI check, it should be passing now.
Edit: not sure why the CI check is failing.
@shawntabrizi @bkchr Do you have an idea why is diener failing in gitlab-check-dependent-polkadot?
@shawntabrizi @bkchr Do you have an idea why is diener failing in
gitlab-check-dependent-polkadot?
You need to do cargo update -p polkadot-runtime-common in your Cumulus pr and push these changes.
