substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Alliance pallet: retirement notice call

Open muharem opened this issue 3 years ago • 10 comments

Fixes https://github.com/paritytech/substrate/issues/11936

Current implementation of retirement has a bug, which makes it impossible to retire for a member if there was even a not enacted proposal to kick the member.

In the PR we introducing a new retirement_notice call, required to be executed by a member before retiring. The notice will start a 'retirement period' that has to pass in order to retire. The required period prevents a misbehaving member to retire before it will be kicked and slashed.

The PR does not cover next use cases:

  • if alliance does not execute the voted proposal to kick a misbehaving member, the member can retire without being slashed;
  • a member can not revoke the retirement process if retirement notice was given. It must retire and join alliance again if desires;

muharem avatar Aug 03 '22 15:08 muharem

/bench pallet pallet_alliance

muharem avatar Aug 04 '22 09:08 muharem

/cmd queue -c bench-bot $ pallet dev pallet_alliance

@muharem the syntax is here https://github.com/paritytech/pipeline-scripts/issues/63

ggwpez avatar Aug 04 '22 09:08 ggwpez

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1719871 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 4-d46fb067-71de-480e-a40e-58ff9f432176 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 04 '22 09:08 command-bot[bot]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1719871 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1719871/artifacts/download.

command-bot[bot] avatar Aug 04 '22 09:08 command-bot[bot]

/cmd queue -c bench-bot $ pallet dev pallet_alliance

muharem avatar Aug 04 '22 12:08 muharem

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721126 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 6-ee0c4611-5302-4ae0-a583-b15a6cc45272 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 04 '22 12:08 command-bot[bot]

/cmd queue -c bench-bot $ pallet dev pallet_alliance

The benchbot does not push anything if you change the branch in between.

ggwpez avatar Aug 04 '22 13:08 ggwpez

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721128 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 7-6de5d2ca-1b3f-438c-adc2-bc15050571b3 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 04 '22 13:08 command-bot[bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721126 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721126/artifacts/download.

command-bot[bot] avatar Aug 04 '22 13:08 command-bot[bot]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721128 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1721128/artifacts/download.

command-bot[bot] avatar Aug 04 '22 13:08 command-bot[bot]

Mostly looks good, but needs some minor fixes for clarity it seems.

ruseinov avatar Aug 24 '22 09:08 ruseinov

/cmd queue -c bench-bot $ pallet dev pallet_alliance

muharem avatar Aug 26 '22 11:08 muharem

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1779299 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 35-a8a5785a-c81c-40e5-b220-2c0876aaf06e to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 26 '22 11:08 command-bot[bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1779299 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1779299/artifacts/download.

command-bot[bot] avatar Aug 26 '22 11:08 command-bot[bot]

bot merge

muharem avatar Aug 29 '22 16:08 muharem