substrate Replace `T::AccountId` with `<T::Lookup as StaticLookup>::Source`

Replace `T::AccountId` with `<T::Lookup as StaticLookup>::Source`

Open Doordashcon opened this issue 3 years ago • 9 comments

Fixes #6042

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

Jun 15 '22 06:06 Doordashcon

cc @kianenigma

Jun 26 '22 11:06 Doordashcon

Overall looks good, I wonder if anyone has an idea to reduce the clutter a bit?

cc @gilescope

Jul 05 '22 15:07 Doordashcon

Could be a good case for using type alias? Maybe called AccoundIdLookup or some such?

Jul 06 '22 06:07 gilescope

Could be a good case for using type alias? Maybe called AccoundIdLookup or some such?

Sounds good, If this works @kianenigma I'll go right ahead and implement it.

Jul 07 '22 07:07 Doordashcon

Yeah perhaps AccountIdLookupOf<T>.

Jul 07 '22 12:07 kianenigma

CI and git conflicts need to go away though.

Jul 13 '22 17:07 kianenigma

glad to be of help @kianenigma

Jul 14 '22 01:07 Doordashcon

@athei please review

Jul 21 '22 20:07 Doordashcon

This needs label E6-transactionversion

Aug 04 '22 10:08 xlc

Does this PR need any more attention apart from the conflicts?

Aug 13 '22 17:08 Doordashcon

bot merge

Aug 18 '22 09:08 ggwpez

/tip medium

Aug 18 '22 09:08 shawntabrizi

@shawntabrizi A medium tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

Aug 18 '22 09:08 substrate-tip-bot[bot]

Thanks for the tip!

Aug 18 '22 17:08 Doordashcon