Remove `without_storage_info` for the `node-authorization` pallet

[koute]

Part of https://github.com/paritytech/substrate/issues/8629

This PR changes the logic in the following way:

• The well known nodes inserted during genesis are now bound by the MaxPeerIdLength and MaxWellKnownNodes constants. (Previously this wasn't enforced.)
• The reset_well_known_nodes now enforces that the peer IDs passed in the nodes are bound by MaxPeerIdLength. (Previously this wasn't enforced.)
• The reset_well_known_nodes now enforces that the number of nodes is bound by exactly MaxWellKnownNodes. (Previously it enforced a limit of MaxWellKnownNodes - 1, which I assume was an off-by-one error?)
• The set inside of the AdditionalConnections is now bound by the MaxAdditionalConnections constant. (Previously it was uncapped.)
• The add_connections and remove_connections now enforce that the peer IDs passed in the connections are bound by MaxPeerIdLength. (Previously this wasn't enforced.)
• The offchain_worker hook now enforces that the state.peer_id is now at most MaxPeerIdLength long. (Previously this wasn't enforced.)

Marking as D5-nicetohaveaudit since this does change the logic.

Since this enforces extra bounds which weren't previously enforced do we need to do anything extra here?

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[koute]

not stale

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[koute]

not stale

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[koute]

not stale

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[koute]

not stale

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[koute]

not stale

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[juangirini]

@koute do you feel like taking this over again? We will review it 😇

[koute]

@koute do you feel like taking this over again? We will review it

Sure I can. Could I get some feedback as to how this should be done? Is the way I did it okay, or does anything else has to change? (Besides @ggwpez 's comments which I'll address.)

[juangirini]

I think this is pretty much ready. @ggwpez I loop you in as you are more familiar with it to answer koute