substrate-light-ui icon indicating copy to clipboard operation
substrate-light-ui copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

Electron Packaging

Open pmespresso opened this issue 6 years ago • 4 comments
trafficstars

To close this issue, we'd need to:

  • [x] successfully run the electron-builder to generate a distributable
  • [ ] run the executable from multiple different machines
  • [ ] manually test that the features work on each machine

--

I've iceboxed this as we'd need to keep testing this as the project develops, so no point in doing it at this stage, though it's coming up.

pmespresso avatar Jan 05 '19 06:01 pmespresso

What steps are required to close out this issue specifically?

ltfschoen avatar Jan 14 '19 00:01 ltfschoen

Just tried yarn package, and got:

2019-04-16 18:14:08 Blocked connection to WebSockets server from untrusted origin: Some("file://")

amaury1093 avatar Apr 16 '19 16:04 amaury1093

@amaurymartiny I just tried it from the latest master and was able to package it and connect to my local node without a problem.

pmespresso avatar Apr 17 '19 09:04 pmespresso

You're probably right, I just saw the PR from Tomek yesterday to disable CORS when running --dev, so it might be fixed

amaury1093 avatar Apr 17 '19 09:04 amaury1093