substrate-contracts-node icon indicating copy to clipboard operation
substrate-contracts-node copied to clipboard
verified publisher icon paritytech

Update crates to latest master

Open pgherveou opened this issue 1 year ago • 5 comments

pgherveou avatar Apr 08 '24 09:04 pgherveou

WIll this also be a tagged github release?

ascjones avatar Apr 08 '24 10:04 ascjones

WIll this also be a tagged github release?

Correct me if I'm wrong, but all the changes we need for ink5 are in the 1.9.0 release. So, we could release the crates from it. In this PR, we are aligned with the master, but as I understand it is not required to be released now.

smiasojed avatar Apr 08 '24 12:04 smiasojed

I am assuming this is to do with https://github.com/paritytech/ink/pull/1912. If so then I have answered my own question because it will require a github tagged release.

ascjones avatar Apr 08 '24 12:04 ascjones

@cmichi @ascjones, please advise if we need two releases: one aligned with polkadot-release 1.9.0 (fully compatible with ink 5.0.0 and we publish crates), and a second one with this commit, or if we will do just one based on this commit and without publishing crates?

smiasojed avatar Apr 08 '24 12:04 smiasojed

How about the following:

  1. Don't merge this PR yet
  2. Create a new PR with the latest crates.
  3. Do a 0.40 release from master.
  4. Then rebase & merge this PR
  5. New (github tag only) release of 0.41.0

ascjones avatar Apr 08 '24 13:04 ascjones