substrate-archive icon indicating copy to clipboard operation
substrate-archive copied to clipboard

add nix support for dev

Open m0ssc0de opened this issue 3 years ago • 7 comments
trafficstars

m0ssc0de avatar Feb 12 '22 07:02 m0ssc0de

User @m0ssc0de, please sign the CLA here.

cla-bot-2021[bot] avatar Feb 12 '22 07:02 cla-bot-2021[bot]

https://gutier.io/post/development-using-rust-with-nix/ - I think people are switching over to oxalica (The company steve K works for) rather than mozilla as the base these days.

gilescope avatar Feb 14 '22 13:02 gilescope

I ran a successful build with the proposed shell.nix on my NixOS setup, which probably means the PR is ok.

I'm a bit confused about the dependencies though. Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

bernardoaraujor avatar Feb 14 '22 20:02 bernardoaraujor

I'm a bit confused about the dependencies though. Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

Maybe for running the tests?
I think if we want to to fully support this we should add a CI build+test step.

ggwpez avatar Feb 15 '22 10:02 ggwpez

I'm a bit confused about the dependencies though. Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

Maybe for running the tests?
I think if we want to to fully support this we should add a CI build+test step.

CI build+test is indeed important for long term sustainability.

I submitted a similar shell.nix PR to substrate-contracts-node recently but the ink! team rejected it based on the maintenance burden it would add to them.

Perhaps the code owner of this project should be on the loop.

bernardoaraujor avatar Feb 15 '22 15:02 bernardoaraujor

Perhaps the code owner of this project should be on the loop.

We're here reading. Not nix users ourselves (yet) so you are indeed correct that this would have to be community maintained and it is a concern. I'm not opposed to adding it if we see active users step up.

dvdplm avatar Feb 16 '22 14:02 dvdplm

This looks good (if it's decided nix is ok to use for archive), I can post my old nix config too if that's of interest. I think Oxalica is definitely better for managing rust dependencies IMO.

insipx avatar Feb 16 '22 14:02 insipx