substrate-archive icon indicating copy to clipboard operation
substrate-archive copied to clipboard

Cleanup more trait bounds

Open insipx opened this issue 4 years ago • 4 comments

We can clean up trait bounds on our structs that we could not before due to https://github.com/Restioson/xtra/pull/42

insipx avatar Oct 06 '21 10:10 insipx

Is this still relevant? What structs do you have in mind here?

dvdplm avatar Nov 15 '21 14:11 dvdplm

Yeah! Still relevant. The PR I Linked allows us to remove the Send + Sync bounds from our Actor-struct declarations, like here for example:

https://github.com/paritytech/substrate-archive/blob/ff02024da349eb03b238165c501476343bcab9d5/substrate-archive/src/actors/workers/blocks.rs#L42

which will have a ripple effect and hopefully clean up the code elsewhere as well

insipx avatar Nov 15 '21 14:11 insipx

I see, ok. But the PR is not released yet, so we can't do this yet right?

dvdplm avatar Nov 15 '21 15:11 dvdplm

yeah we're just waiting on a release of xtra. Not really high on priorities since it won't change the functionality of archive in any way other than improve the code quality

insipx avatar Nov 15 '21 15:11 insipx