smoldot icon indicating copy to clipboard operation
smoldot copied to clipboard

Backport protocol name changes and `forkId`

Open tomaka opened this issue 3 years ago • 5 comments

https://github.com/paritytech/substrate/pull/10463

tomaka avatar Jan 26 '22 18:01 tomaka

Another smoldot PR later should add support for forkId once Substrate/Polkadot have released a version that uses it.

Does the monthly substrate releases count? I can see that the last "stable" release was in Feb. 2021.

If the answer is yes, can I give this a shot?

melekes avatar Mar 02 '22 11:03 melekes

Yes, go for it!

I don't think we need to maintain backwards compatibility in smoldot, you can just overwrite /paritytech/grandpa with the replacement name.

You should be able to test if it works by running the JS demo and checking if the finalized block updates itself over time.

tomaka avatar Mar 02 '22 12:03 tomaka

cc https://github.com/paritytech/substrate/issues/10969 (I've coincidentally just noticed that when debugging some parachains stuff)

tomaka avatar Mar 03 '22 07:03 tomaka

https://github.com/paritytech/substrate/pull/11938 also now changed other protocol names.

(see also https://github.com/paritytech/polkadot/pull/5849, but it only changes protocols not implemented in smoldot at the moment)

tomaka avatar Aug 12 '22 14:08 tomaka

https://github.com/paritytech/substrate/pull/12545

tomaka avatar Oct 25 '22 08:10 tomaka