schnorrkel-js icon indicating copy to clipboard operation
schnorrkel-js copied to clipboard

Add sign & verify methods w/ signing context param.

Open wilfred-centrality opened this issue 6 years ago • 3 comments

Related to https://github.com/paritytech/schnorrkel-js/issues/12

Introduces signing context interfaces for sign and verify while maintaining back compatibility. Might be an interface to consolidate in a later version.

The upgrade of schnorrkel 0.1 to 0.6 seems to have broken the derives tests. Need guidance on how to proceed.

wilfred-centrality avatar Jul 08 '19 23:07 wilfred-centrality

Your derives tests look like test vectors. We've no test vectors yet because the scheme was not stable https://github.com/w3f/schnorrkel/issues/36 In this case, there were so many breaking changes between 0.1.1 and 0.6.1 that any test vector anywhere should've broken. We're starting an audit this week, which might result in the final breaking changes, so test vectors may become reasonable in early August.

burdges avatar Jul 09 '19 00:07 burdges

The failing tests are unrelated to this PR. If it's not a problem I'm sure I can just update the expected output for each and make them pass again.

PS, any idea how www/tests.js is meant to be instantiated? Or should I not bother

wilfred-centrality avatar Jul 09 '19 04:07 wilfred-centrality

It looks like it's dose some sort of functionality tests I guess. I'm not sure about the js stuff

burdges avatar Jul 09 '19 12:07 burdges