polkadot icon indicating copy to clipboard operation
polkadot copied to clipboard

WIP: Run try-runtime hooks in CI

Open ggwpez opened this issue 2 years ago • 5 comments

Depends on https://github.com/paritytech/substrate/pull/13045 so we can run it in a timely manner.

Currently the pre_ and post_upgrade hooks do not run because of new CLI behavious. Enabling the checks again with --checks.

TODO:

  • [ ] Verify CI output
  • [ ] Remove old migrations, if needed
  • [ ] Remove runtime-migration label after merge

cc @kianenigma

ggwpez avatar Jan 02 '23 17:01 ggwpez

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2217999

paritytech-cicd-pr avatar Jan 03 '23 17:01 paritytech-cicd-pr

bot rebase

ggwpez avatar Jan 04 '23 18:01 ggwpez

Rebased

What's the status here?

kianenigma avatar Feb 14 '23 12:02 kianenigma

What's the status here?

That we probably need to add a new label for the release engies to use, since we cannot expect the try-runtime of master to work, in case Polkadot is not yet on the latest release.

We can add a way to demote the error of an pre_upgrade to a warning, which could improve development speed since we dont always need to re-build and re-try after removing each old migration. Then we either the warning for master and the error on release, or just warning everywhere :shrug:
Having old migrations is not an "error" anyway. @kianenigma

ggwpez avatar Feb 20 '23 16:02 ggwpez

bot rebase

ggwpez avatar Mar 30 '23 15:03 ggwpez

Rebased

CI is not running here?!
Change is not really high prio rn so going to merge into the next MR.

ggwpez avatar Mar 30 '23 15:03 ggwpez