paritytech
ci: remove check-runtime job
Alternative to #5858.
See https://github.com/paritytech/polkadot/pull/5858#issuecomment-1205153586 for justification.
The original purpose of the check was to ensure we bump the spec_version on releases properly based on what's changed in master. Our current release process bumps it always, making this check obsolete.
One downside I can think of is a potential of getting "state root mismatch" when running e.g. burn-in from master. To avoid that, we could:
- set the
spec_versionin master to some different value (e.g. 999999) than in release branches - make
spec_versionbump in master a part of the release process: #4268
We should keep this test and only remove it from non release branches and especially master.
It is good to have the check on the release branches since we have it. I would prefer how it is done in https://github.com/paritytech/polkadot/pull/5858 The check should never fail (besides if we create the release branch and the versions were not bumped yet but we are working on scripts that will prevent this case) and if it does, it means we messed up and really want to know about it.
Nowadays, the version in master should be bumped to the same version that we just released. This is usually done in || and we make a PR for the release and the same for master.
I don't think it is a good idea to use a bigger runtime spec_version such as 9999 for master.
Say we just released 9270, is there any issue with master now being 9270 until the next release ?
Say we just released 9270, is there any issue with master now being 9270 until the next release ?
An issue mentioned in the description (only relevant for the native runtime):
a potential of getting "state root mismatch" when running e.g. burn-in from master
So once we release 9270, the master should be bumped to 9280 (or, alternatively, master should be permanently on 99..99).
It is good to have the check on the release branches
We could keep it for release branches, but then we won't see this check on PRs on github to release branches. Would it still be useful this way? I guess this is more of a question for release engineers.
If we keep this check on PRs, then the release engineering team should bump the spec_version on master. Otherwise, as soon as the release is done, all PRs turn red, although they haven't changed anything. This is very annoying.
I think we should just remove it. If someone wants it for the release branch or whatever, it can come back. However, each release we have this test failing for multiple days and it is just annoying!
Anyone knows why the stable job didn't return any status? Is it maybe depending somehow on this check-runtime check?
Anyone knows why the stable job didn't return any status? Is it maybe depending somehow on this check-runtime check?
My bad, should be fixed now.
#5858 now also disables it for PRs, so it comes down to whether release engineers find this check being run on release branch (but not PRs to it) useful or not
I merged https://github.com/paritytech/polkadot/pull/5858 since @chevdor confirmed that release team still needs that job. Probably we can close this PR
