polkadot icon indicating copy to clipboard operation
polkadot copied to clipboard

Add note for importing keys and updating packages with sudo

Open DerekCrosson opened this issue 2 years ago • 7 comments

A note for people using a non-root user with elevated privileges. Myself and someone else experienced this today while installing Polkadot using Ansible.

Is it cool if this PR is from master since it's a small update? Sorry :)

DerekCrosson avatar Jun 09 '22 21:06 DerekCrosson

User @DerekCrosson, please sign the CLA here.

cla-bot-2021[bot] avatar Jun 09 '22 21:06 cla-bot-2021[bot]

Hello @DerekCrosson, thank you for your PR. This is a good addition. I would prefer not to mention the "above" code to avoid duplication. We can simply show how it works as sudo.

To make things cleared, you could extract the previous instruction as a sub-chapter and add a new sudo/root specific chapter. That would help users picking quickly the part they need.

Sure, will get to this a bit later today or tomorrow 🙂

DerekCrosson avatar Jun 13 '22 15:06 DerekCrosson

Hello @DerekCrosson, thank you for your PR. This is a good addition. I would prefer not to mention the "above" code to avoid duplication. We can simply show how it works as sudo.

To make things cleared, you could extract the previous instruction as a sub-chapter and add a new sudo/root specific chapter. That would help users picking quickly the part they need.

Hey, @chevdor 👋🏾

Sorry, I only got to this now. When you have a chance, please have a look to see if my changes are okay? I'm not sure if I've made the changes correctly or if I can use better wording

DerekCrosson avatar Jul 22 '22 14:07 DerekCrosson

bot rebase

chevdor avatar Aug 19 '22 08:08 chevdor

Branch is already up-to-date

LGTM, please consider the few suggestions I made.

Thanks, @chevdor! I've just made the suggested changes :)

DerekCrosson avatar Aug 19 '22 10:08 DerekCrosson

I requested additional reviews to get it approved and we will need to convince CI that it is OK :) We may need a rebase but I can do that when the tests are fixed in master.

chevdor avatar Aug 19 '22 13:08 chevdor