polkadot icon indicating copy to clipboard operation
polkadot copied to clipboard
verified publisher icon paritytech

Enable the `improved_panic_error_reporting` feature in `sp-io` for our runtimes in a few releases

Open koute opened this issue 3 years ago • 2 comments

Substrate PR: https://github.com/paritytech/substrate/pull/10741 Background issue: https://github.com/paritytech/substrate/issues/10585

We should wait for a few releases until people have upgraded their clients (so that the new required host function is available) and then switch this feature on.

koute avatar Feb 09 '22 09:02 koute

dq: what does "enable" actually mean here? Does this need a Polkadot PR?

dvdplm avatar Jun 13 '22 08:06 dvdplm

Yes, there is a feature that needs to be activated. I think it can be done now, but there is no real need to get it done for the next release.

bkchr avatar Jun 13 '22 09:06 bkchr

Does fixing this also fix https://github.com/paritytech/substrate/issues/11828?

ordian avatar Nov 22 '22 13:11 ordian

Yes, as I have commented on the issue.

@koute it is now finally time to enable this :P I think we can just remove the feature and have it enabled always.

bkchr avatar Nov 22 '22 13:11 bkchr

Indeed; this was included in Polkadot 0.9.17, and the newest version that explicitly pops up in our telemetry is 0.9.24, so should be fine to enable it.

I'll push a PR tomorrow morning.

koute avatar Nov 22 '22 13:11 koute

Thank you. Important here being any way that all validators support this and they support this for sure.

bkchr avatar Nov 22 '22 14:11 bkchr