polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

update XcmPaymentApi query_delivery_fees to return the fee based on V…

Open jpserrat opened this issue 7 months ago • 2 comments

Closes #7061

@acatangiu Two questions.

  1. where is the best place to write the tests for the AssetHubWestend impl?
  2. For the other places that are implementing the XcmPaymentApi I've just added the VersionedAssetId without any use. Should I implement this for all of them?

jpserrat avatar Apr 22 '25 11:04 jpserrat

Thank you for contributing! 😁 Left some comments

franciscoaguirre avatar Apr 23 '25 09:04 franciscoaguirre

Thank you for all the comments Francisco!

jpserrat avatar Apr 23 '25 17:04 jpserrat

I'm closing this in favor of https://github.com/paritytech/polkadot-sdk/pull/9963

franciscoaguirre avatar Oct 10 '25 22:10 franciscoaguirre

I've just noticed that you responded Francisco. Thank you for the continuation, I'll take a look at what you did to learn a little bit more! Sorry for not finishing this.

jpserrat avatar Oct 11 '25 11:10 jpserrat