polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard

check if at least one of the transactions satisfy existential deposit

Open jpserrat opened this issue 1 year ago • 1 comments

Closes #4242

Hey @acatangiu, created this PR as a draft. I still have to figure things out. Is this what you had in mind? Which error should I return in case all transactions fail?

jpserrat avatar May 14 '24 22:05 jpserrat

@acatangiu Sorry for the long delay with this one. One last thing, I'm not sure how to do the tests for this one. What do you guys usually do with the xcm executor test?

jpserrat avatar Jun 09 '24 19:06 jpserrat

@Jpserrat is it ok if we take over and take this over the finish line? or do you want to do it yourself?

Either way, please add your Polkadot address to the PR description so we can propose a tip for the work done so far.

acatangiu avatar Jul 12 '24 16:07 acatangiu

Hi @acatangiu sorry for the long delay with this one, I did the fixes that you requested, I'm only missing the tests. Can you do this part?

jpserrat avatar Jul 18 '24 09:07 jpserrat

Hi @acatangiu sorry for the long delay with this one, I did the fixes that you requested, I'm only missing the tests. Can you do this part?

Sure. Can you check what happened with the latest push you did? it messed up the PR, it's showing a million changes now.

acatangiu avatar Jul 18 '24 09:07 acatangiu

Fixed!

jpserrat avatar Jul 18 '24 10:07 jpserrat

bot bench --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 11:08 franciscoaguirre

bot bench xcm westend pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 11:08 franciscoaguirre

bot bench $ xcm westend pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 11:08 franciscoaguirre

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 11:08 franciscoaguirre

bot bench polkadot-pallet --subcommand=xcm --runtime=rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-assets --subcommand=xcm --runtime=asset-hub-westend --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-assets --subcommand=xcm --runtime=asset-hub-rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-collectives --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-coretime --subcommand=xcm --runtime=coretime-westend --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-coretime --subcommand=xcm --runtime=coretime-rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-rococo --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-westend --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-contracts --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-people --subcommand=xcm --runtime=people-westend --pallet=pallet_xcm_benchmarks::fungiblez bot bench cumulus-people --subcommand=xcm --runtime=people-rococo --pallet=pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 11:08 franciscoaguirre

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::fungible bot bench polkadot-pallet --subcommand=xcm --runtime=rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-assets --subcommand=xcm --runtime=asset-hub-westend --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-assets --subcommand=xcm --runtime=asset-hub-rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-collectives --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-coretime --subcommand=xcm --runtime=coretime-westend --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-coretime --subcommand=xcm --runtime=coretime-rococo --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-rococo --pallet=pallet_xcm_benchmarks::fungible bot bench cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-westend --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-contracts --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible

bot bench cumulus-people --subcommand=xcm --runtime=people-westend --pallet=pallet_xcm_benchmarks::fungiblez bot bench cumulus-people --subcommand=xcm --runtime=people-rococo --pallet=pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 14:08 franciscoaguirre

Working on a regression test for this

acatangiu avatar Aug 08 '24 15:08 acatangiu

bot bench cumulus-people --subcommand=xcm --runtime=people-westend --pallet=pallet_xcm_benchmarks::fungible

franciscoaguirre avatar Aug 08 '24 18:08 franciscoaguirre

bot bench cumulus-people --subcommand=xcm --runtime=people-westend --pallet=pallet_xcm_benchmarks::generic bot bench cumulus-people --subcommand=xcm --runtime=people-rococo --pallet=pallet_xcm_benchmarks::generic

franciscoaguirre avatar Aug 09 '24 07:08 franciscoaguirre

bot clean

acatangiu avatar Aug 09 '24 11:08 acatangiu

We are migrating the command bot to be a GitHub Action

Please, see the documentation on how to use it

github-actions[bot] avatar Aug 09 '24 11:08 github-actions[bot]

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 3/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6955504

paritytech-cicd-pr avatar Aug 09 '24 14:08 paritytech-cicd-pr

/tip small

kianenigma avatar Aug 12 '24 09:08 kianenigma

@kianenigma A referendum for a small (4 KSM) tip was successfully submitted for @Jpserrat (FkB6QEo8VnV3oifugNj5NeVG3Mvq1zFbrUu4P5YwRoe5mQN on kusama).

Referendum number: 440. tip

substrate-tip-bot[bot] avatar Aug 12 '24 09:08 substrate-tip-bot[bot]

The referendum has appeared on Polkassembly.

substrate-tip-bot[bot] avatar Aug 12 '24 09:08 substrate-tip-bot[bot]