polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard

Release `frame-omni-bencher`

Open bkontur opened this issue 1 year ago • 5 comments

I have a PoC for using frame-omni-bencher in the fellows repo: https://github.com/polkadot-fellows/runtimes/pull/298. However, since there is no released version, I have to build it from the sources each time for every runtime pipeline, which is a waste of resources.

How to re-use frame-omni-bencher for fellows or elsewhere:

  • [ ] create a github action for that, as we have for try-runtime-gha e.g. used here
  • [ ] release for cargo install, e.g. as we have for zepter, cargo install --locked -q zepter
  • [ ] release just as binary to polkadot-sdk repo/release, so we just setup downloading from polkadot-sdk in fellows CI?
  • [ ] other?

cc: @ggwpez

bkontur avatar May 02 '24 10:05 bkontur

How long is the build time?
Binary release is probably the fastest for CI. AFAIK the GHA for try-runtime is also doing that.

@EgorPopelyaev do you know what would be the steps to attach another binary to the release?

ggwpez avatar May 02 '24 10:05 ggwpez

How long is the build time?

@ggwpez https://github.com/polkadot-fellows/runtimes/actions/runs/8923074053/job/24506630345?pr=298#step:11:1001

 Compiling frame-omni-bencher v0.1.0 (/home/runner/work/runtimes/runtimes/polkadot-sdk/substrate/utils/frame/omni-bencher)
    Finished release [optimized] target(s) in 14m 16s

bkontur avatar May 02 '24 17:05 bkontur

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

EgorPopelyaev avatar May 07 '24 09:05 EgorPopelyaev

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

ok, thank you, I will check later, and also I will change short-benchmarks to use frame-omni-bencher instead of ./artifacts/polkadot

bkontur avatar May 07 '24 09:05 bkontur

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

@EgorPopelyaev I added job that should build that binary here: https://github.com/paritytech/polkadot-sdk/pull/4405/files#diff-56213afe4ff9406795cf7f877c62e3f277dc7edaeccef4a26260f50f776663f0 but I haven't tested it, I don't know how exactly and I don't want to trigger draft release, can you please check/test it and also could you please help with integrating it to release?

bkontur avatar May 14 '24 09:05 bkontur

would it not be possible to create a CI image that already has this stuff installed? That seems like the more correct solution to me.

kianenigma avatar May 20 '24 09:05 kianenigma