polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

Restoring disable-runtime-api for test chains

Open bolajahmad opened this issue 1 year ago • 2 comments

Adds disable-runtime-api back to rococo and westend. Previously removed.

Partly closes, #1621 . Kusams and Polkadot will be updated on the runtimes codebase in a seperate PR.

bolajahmad avatar Apr 29 '24 12:04 bolajahmad

User @bolajahmad, please sign the CLA here.

cla-bot-2021[bot] avatar Apr 29 '24 12:04 cla-bot-2021[bot]

@bolajahmad could you please revert the changes that are not related to your pr?

bkchr avatar May 19 '24 20:05 bkchr

@bolajahmad could you please revert the changes that are not related to your pr?

Hi @bkchr, i tried to cleanup the branch and revert unrelated changes to my PR. I've removed the changes that seemed weird and it should be good. I'm sorry to bother you when you're reviewing my changes but I can't find anymore unrelated changes in this PR. I'll appreciate if you mention something specific you think I need to remove/revert too🙏🏼

bolajahmad avatar May 20 '24 04:05 bolajahmad

https://github.com/paritytech/polkadot-sdk/pull/4325/files#diff-5264d812f7aadfc486efffd3322b11c8dee5e8ddf2e77e0a9e70b573f3d2afddR91 here for example where you import AccountIdLookup which was not there before.

Or the formatting changes here

bkchr avatar May 22 '24 12:05 bkchr

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-clippy Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7063196

paritytech-cicd-pr avatar Aug 17 '24 22:08 paritytech-cicd-pr

The issue was closed as not needed anymore, so we can do the same with this pr.

bkchr avatar Sep 19 '24 19:09 bkchr