polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard
Published 1 week ago • verified publisher icon paritytech

Implement `CheckMetadataHash` extension

Open bkchr opened this issue 1 year ago • 11 comments

This implements the CheckMetadataHash extension as described in RFC78.

Besides the signed extension, the substrate-wasm-builder is extended to support generating the metadata-hash.

Closes: https://github.com/paritytech/polkadot-sdk/issues/291

bkchr avatar Apr 24 '24 21:04 bkchr

@bkchr will this be backported to earlier releases of the polkadot-sdk and if so, which ones?

mustermeiszer avatar May 07 '24 08:05 mustermeiszer

I think at least back to 1.7.0 for use in https://github.com/polkadot-fellows/runtimes/issues/288

joepetrowski avatar May 07 '24 08:05 joepetrowski

Thanks, thats great!

mustermeiszer avatar May 07 '24 09:05 mustermeiszer

We probably even go back until 1.1. Need to check how complicated that will get.

bkchr avatar May 07 '24 10:05 bkchr

@TarikGul @josepot can you please take care to make pjs/papi ready for this new signed extension? Right now the easiest way would be to just pass 0u8 as mode (to disable any metadata hash checking).

bkchr avatar May 15 '24 11:05 bkchr

@TarikGul @josepot can you please take care to make pjs/papi ready for this new signed extension? Right now the easiest way would be to just pass 0u8 as mode (to disable any metadata hash checking).

Sounds good, I will make it a priority!

TarikGul avatar May 15 '24 11:05 TarikGul

@TarikGul @josepot can you please take care to make pjs/papi ready for this new signed extension? Right now the easiest way would be to just pass 0u8 as mode (to disable any metadata hash checking).

Will do! for sure!

josepot avatar May 15 '24 15:05 josepot

Is this a breaking change? If that's the case, shouldn't the tx version be updated for each chain?

adelove-ledger avatar May 16 '24 08:05 adelove-ledger

Is this a breaking change? If that's the case, shouldn't the tx version be updated for each chain?

I can bump this, but this will require the new ledger app any way that will not require the transaction_version anymore.

bkchr avatar May 16 '24 19:05 bkchr

Should we add the CheckMetadataHash extension to the kitchensink runtime too?

jsdw avatar May 17 '24 16:05 jsdw

Should we add the CheckMetadataHash extension to the kitchensink runtime too?

Done

bkchr avatar May 17 '24 19:05 bkchr

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 3/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6256948

paritytech-cicd-pr avatar May 22 '24 07:05 paritytech-cicd-pr

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-generic-ledger-app/4295/26

Polkadot-Forum avatar May 22 '24 20:05 Polkadot-Forum

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-generic-ledger-app/4295/27

Polkadot-Forum avatar May 29 '24 17:05 Polkadot-Forum

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-digest-13-jun-2024/8598/1

Polkadot-Forum avatar Jun 13 '24 07:06 Polkadot-Forum