parity-common icon indicating copy to clipboard operation
parity-common copied to clipboard

Silence uint warns

Open pmarangone opened this issue 1 year ago • 2 comments

Hello! I'm having a hard time silencing the warns from uint initialization. I tried adding allow = ["clippy::ptr_offset_with_cast"] to .clippy.toml but this hides another warns from the code. If you guys could suggest a solution to this. Also, if this is more an issue with rust-clippy, no problem, I can move this issue there.

image

pmarangone avatar Aug 11 '22 17:08 pmarangone

Hey @pmarangone, the ideal way to resolve this would be to:

  1. Figure out which clippy warnings are legitimate and fix them in uint. (medium)
  2. Put an ignoring attribute on the rest in uint (easy)
  3. Add CI clippy check (easy)

ordian avatar Aug 14 '22 16:08 ordian

CI check is missing

ordian avatar Feb 01 '23 19:02 ordian