diener icon indicating copy to clipboard operation
diener copied to clipboard

feature request: --all flag on patch

Open gilescope opened this issue 3 years ago • 1 comments

If I point diener at a particular cumulus then whatever version of polkadot that that cumulus is pointing to must be also patched / updated to. And that polkadot is referring to a version of substrate so that also needs to be patched / updated to. ( The point is by doing diener patch --crates-to-patch ../cumulus --cumulus for example there's no choice in which polkadot or substrate version to use, it must be whatever polkadot and substrate branch/path that ../cumulus is pointing to)

This would make diener a joy to use and would remove the tedium of running the command 2 - 3 times with different arguments.

(feel free to bikeshed the flag name...)

gilescope avatar Oct 06 '22 13:10 gilescope

That's a nice idea. Indeed today, we are handling the fetching of "right" references with bash scripts and we feed the result to multiple diener calls.

diener is currently targetting one workspace. For your feature to work, we'd need to pass the path of the other repo(s).

The need to know the locations of the other repos in several scripts is something we solved by defining the following ENV:

REPO_SUBSTRATE=/projects/substrate
REPO_POLKADOT=/projects/polkadot
REPO_CUMULUS=/projects/cumulus

Those could use be used as defaults while allowing the user to pass specific locations new via cli args.

For this to work, repos need to be in a "clean state" where they reference one single version of their dependencies (which should be the case, but this is something to ensure).

chevdor avatar Oct 06 '22 14:10 chevdor