cumulus icon indicating copy to clipboard operation
cumulus copied to clipboard

Transfer asset via bridge pallet xcm with dynamic fees and back-pressure

Open bkontur opened this issue 2 years ago • 12 comments

This PR extends asset transfer with pallet_xcm PR, adding dynamic fees and back-preassure mechanism.

You can review bridges subdirectory either here or in its dedicated PR in parity-bridges-common where it was originally developed.

TODO:

  • [x] set/check static "base fee" in BridgeTable (according to ExportMessage calculation from BridgeHub)
  • [x] set/verify default value for XcmBridgeHubRouterByteFee (actaully is TransactionByteFee) or setup governance call?
  • [x] add possiblity to change XcmBridgeHubRouterByteFee via governance + test
  • [x] set up benchmarks for router WeightInfo
  • [x] add support/barrier for unpaid report_congestion + test
  • [ ] assert FeeManager charged fees in test when merged https://github.com/paritytech/polkadot/pull/7005
    • search code for // TODO:check-parameter: change and assert in tests when (https://github.com/paritytech/polkadot/pull/7005) merged

bkontur avatar Aug 11 '23 13:08 bkontur

bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-kusama bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-polkadot

bkontur avatar Aug 16 '23 13:08 bkontur

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 34-c3c2d655-293d-4095-a2ec-8e927c2767d7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 16 '23 13:08 command-bot[bot]

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 35-d6b15980-47a9-45ac-bca9-2e8ae172ed52 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 16 '23 13:08 command-bot[bot]

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837/artifacts/download.

command-bot[bot] avatar Aug 16 '23 13:08 command-bot[bot]

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838/artifacts/download.

command-bot[bot] avatar Aug 16 '23 13:08 command-bot[bot]

bot rebase

bkontur avatar Aug 16 '23 19:08 bkontur

Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "merge" "origin/bko-transfer-asset-via-bridge-pallet-xcm" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-kusama bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-polkadot

bkontur avatar Aug 17 '23 08:08 bkontur

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 44-d8670105-e574-4ff2-a0fa-24b3944cdc66 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 17 '23 08:08 command-bot[bot]

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 45-eb90cbbd-2544-4934-9478-8e8cd18af08a to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] avatar Aug 17 '23 08:08 command-bot[bot]

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271/artifacts/download.

command-bot[bot] avatar Aug 17 '23 09:08 command-bot[bot]

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272/artifacts/download.

command-bot[bot] avatar Aug 17 '23 09:08 command-bot[bot]