cumulus icon indicating copy to clipboard operation
cumulus copied to clipboard

Add overhead benchmark to parachain-template

Open kalaninja opened this issue 2 years ago • 4 comments

Adds benchmark overhead that was missing in the previous PR #1156

kalaninja avatar Jul 12 '23 11:07 kalaninja

Fot the storage benchmark there seems to be one for the asset hubs:

This test is from polkadot-parachain. I decided to split this into 2 PRs. So the overhead benchmark and the test for collator will come in a different PR.

Is there a test to check that the new command works?

I tested this one manually with cargo run -p parachain-template-node -- benchmark overhead

kalaninja avatar Jul 12 '23 12:07 kalaninja

@ggwpez the test was added in #2900

kalaninja avatar Jul 19 '23 06:07 kalaninja

@kalaninja could we run benchbot here to see that it works? maybe for parachain-template it is not configured

bkontur avatar Jul 19 '23 12:07 bkontur

@kalaninja could we run benchbot here to see that it works? maybe for parachain-template it is not configured

We can run it for the asset hubs over here once its merged and the bench bot is updated: https://github.com/paritytech/cumulus/pull/2900. The Bot does not care about templates, since they dont need correct weights.

ggwpez avatar Jul 19 '23 12:07 ggwpez