cumulus icon indicating copy to clipboard operation
cumulus copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

companion for #13992

Open niklasad1 opened this issue 2 years ago • 6 comments

niklasad1 avatar May 10 '23 11:05 niklasad1

Your companion in substrate will pass if you bump jsonrpsee-core here: https://github.com/paritytech/cumulus/blob/35a443d0c62abedd452343beebb0ce08a0d73123/client/relay-chain-interface/Cargo.toml#L20

skunert avatar May 11 '23 09:05 skunert

Thanks @skunert

Heads up we added https://docs.rs/jsonrpsee-ws-client/latest/jsonrpsee_ws_client/struct.WsClient.html#method.on_disconnect, I noticed the you have implemented some reconnect logic perhaps it could be simplified ^^

niklasad1 avatar May 11 '23 10:05 niklasad1

Thanks @skunert

Heads up we added https://docs.rs/jsonrpsee-ws-client/latest/jsonrpsee_ws_client/struct.WsClient.html#method.on_disconnect, I noticed the you have implemented some reconnect logic perhaps could be simplified ^^

Nice! I will come back to this.

skunert avatar May 11 '23 10:05 skunert

bot rebase

niklasad1 avatar May 11 '23 12:05 niklasad1

Rebased

paritytech-processbot[bot] avatar May 11 '23 12:05 paritytech-processbot[bot]

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2820308

paritytech-cicd-pr avatar May 11 '23 12:05 paritytech-cicd-pr