cargo-contract icon indicating copy to clipboard operation
cargo-contract copied to clipboard

WIP: Relates to Closed PR #1134 and Issue #674. Add suri_path and password_path options to CLI

Open ltfschoen opened this issue 1 year ago • 3 comments

Summary

Closes #674

  • [X] y | Does it introduce breaking changes?
  • [X] n | Is it dependent on the specific version of ink or pallet-contracts?

See description here https://github.com/paritytech/cargo-contract/pull/1134#issue-1728745292

Allows user to provide either suri + password, or suri_path + password_path

Status

TODO's are included in the PR that I haven't been able to resolve, so I can't compile and update Cargo.lock

Description

Re-open PR #1134 that was previously closed. See description here https://github.com/paritytech/cargo-contract/pull/1134#issue-1728745292

Checklist before requesting a review

  • [ ] My code follows the style guidelines of this project
  • [X] I have added an entry to CHANGELOG.md
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

ltfschoen avatar Apr 18 '24 12:04 ltfschoen

@ltfschoen Sorry for such a late answer, are you up for merging master and resolving the conflicts?

cmichi avatar Nov 20 '24 12:11 cmichi

@cmichi sure, i can't right at the moment though as i'm about to board a long flight. i'll have plenty of time in a couple of weeks, but i'll try and look into it asap

ltfschoen avatar Nov 20 '24 13:11 ltfschoen

@ltfschoen Sorry for such a late answer, are you up for merging master and resolving the conflicts?

I've merged master and resolved the conflicts.

ltfschoen avatar Dec 18 '24 12:12 ltfschoen