ramp-workflow icon indicating copy to clipboard operation
ramp-workflow copied to clipboard

Naming

Open kegl opened this issue 7 years ago • 3 comments

Consider renaming train_is to train_idxs and labels to label_names.

kegl avatar Jun 21 '17 12:06 kegl

I guess you meant train_is to train_ids or train_idx

aboucaud avatar Jun 21 '17 13:06 aboucaud

Since that there is couple of occurences with idxs in scikit-learn, I would agree with it :D

https://github.com/scikit-learn/scikit-learn/search?utf8=%E2%9C%93&q=idxs&type=

glemaitre avatar Jun 21 '17 21:06 glemaitre

But most of the time sklearn uses either just train, test = cv.splilt(..) or train_index, test_index = cv.split(..)

jorisvandenbossche avatar Jun 22 '17 11:06 jorisvandenbossche