ramp-workflow icon indicating copy to clipboard operation
ramp-workflow copied to clipboard

Rename and single library

Open kegl opened this issue 7 years ago • 4 comments

We should rename ramp-workflow to ramp-sdk. Existing starting kits will need to be updated.

We should have a single repo ramp and subrepos frontend, backend, and sdk. Then let users pip install those separately. Testing and PRs will be easier.

kegl avatar Jun 21 '17 12:06 kegl

+1 for sdk

agramfort avatar Jun 21 '17 21:06 agramfort

Would it make sense to have submodule? Like in xgboost where you have a different repository for the core library, etc.

glemaitre avatar Jun 21 '17 21:06 glemaitre

Would it make sense to have submodule? Like in xgboost where you have a different repository for the core library, etc.

It might be easier to have a single repository with all the components or multiple repositories with fixed versions for each component IMO. Generally using git submodules makes things more complicated, particularly for new contributors ( e.g. can't just clone, also need to run git submodule update --init --recursive) etc.). I'm not sure of xgboost experience of it, but jupyter is not using them as far as I know, and here there are a few fairly negatives blog posts about git submodules in [1], [2], etc.

rth avatar Jun 22 '17 05:06 rth

                                                                                  You are right. Speaking with joris, the issue tracker and PRs handling would be rather complicated.                                                                                                                                                                                                                                                                                                                                         

glemaitre avatar Jun 22 '17 08:06 glemaitre