website icon indicating copy to clipboard operation
website copied to clipboard

Document changing the webextension manifest name

Open mischnic opened this issue 3 years ago • 6 comments

mischnic avatar Nov 01 '22 16:11 mischnic

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:16am

vercel[bot] avatar Nov 01 '22 16:11 vercel[bot]

Seems fine for now, however, actual flexibility of having any file name for the manifest will be very much helpful in future.

akash07k avatar Nov 01 '22 17:11 akash07k

Turns out this actually doesn't work yet because of this hardcoded name check: https://github.com/parcel-bundler/parcel/blob/c3bbe0a6160186f496ca2f9e9bead9376c0522f1/packages/runtimes/webextension/src/WebExtensionRuntime.js#L18 We'll have to change that to just rely on some asset meta property...

mischnic avatar Nov 12 '22 09:11 mischnic

Exactly, that will be great.

On 11/12/2022 3:04 PM, Niklas Mischkulnig wrote:

Turns out this actually doesn't work yet because of this hardcoded name check: https://github.com/parcel-bundler/parcel/blob/c3bbe0a6160186f496ca2f9e9bead9376c0522f1/packages/runtimes/webextension/src/WebExtensionRuntime.js#L18 We'll have to change that to just rely on some asset meta property...

— Reply to this email directly, view it on GitHub https://github.com/parcel-bundler/website/pull/1052#issuecomment-1312425002, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQWBM6E2KZXWOGS6TIRJ73WH5QB7ANCNFSM6AAAAAARUG5YII. You are receiving this because you commented.Message ID: @.***>

akash07k avatar Nov 12 '22 13:11 akash07k

If you stop hard-coding and rely on meta property, the build will go through. However, since the output file name remains the same, it cannot be loaded as a browser extension. I want to convert the file name to manifest.json when outputting, but I can't think of a good way to do it...😞. Do you have any good ideas?

kuroppe1819 avatar Mar 23 '23 02:03 kuroppe1819

@kuroppe1819 using namer? https://parceljs.org/plugin-system/namer

sergey-shpak avatar Apr 04 '23 22:04 sergey-shpak