watcher icon indicating copy to clipboard operation
watcher copied to clipboard

Improve support for mounted file systems on macOS

Open DavidGoldman opened this issue 3 years ago • 3 comments

Some mounted file systems report a creation time of 0 - we want to support these systems reporting a file as created and modified and properly treat it as created.

DavidGoldman avatar Aug 23 '22 21:08 DavidGoldman

@devongovett Thoughts on merging this? Also, is there a proper way to run the tests - they don't seem to be passing (unrelated from my change from what I can tell)?

DavidGoldman avatar Sep 19 '22 17:09 DavidGoldman

Is there a way I can test this change?

devongovett avatar Sep 19 '22 17:09 devongovett

It happens internally for our own mounted VFS, but I think you might be able to repro with an NFS client or perhaps with a normal file system if you change the latency here to be greatly increased and then write and modify the file (while keeping the ctime as 0)

DavidGoldman avatar Sep 19 '22 19:09 DavidGoldman