parcel icon indicating copy to clipboard operation
parcel copied to clipboard

[WIP] Package on main thread for small rebuilds

Open thebriando opened this issue 3 years ago • 1 comments

↪️ Pull Request

This change prevents WriteBundlesRequest from serializing across all workers with small rebuilds which should improve save/warm build times when small changes that only impact a single bundle are made to the project.

✔️ PR Todo

  • [ ] Added/updated unit tests for this change
  • [ ] Filled out test instructions (In case there aren't any unit tests)
  • [ ] Included links to related issues/PRs

thebriando avatar Sep 20 '22 03:09 thebriando

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.39s +7.00ms
Cached 319.00ms -63.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 8.77s -18.00ms
Cached 428.00ms -1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.47m +411.00ms
Cached 2.50s -70.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.31s -92.00ms
Cached 266.00ms -17.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

parcel-benchmark avatar Sep 20 '22 03:09 parcel-benchmark

I've refactored the WorkerFarm in a way that should make this a bit simpler to implement: #8589.

devongovett avatar Oct 31 '22 01:10 devongovett