lightningcss icon indicating copy to clipboard operation
lightningcss copied to clipboard

When rendering declarations of KeyFrames disable minification

Open DanielJoyce opened this issue 1 year ago • 2 comments

so that KeyFrame transformations are not broken

  • Added Todo to TransformList::to_css as it needs to be refactored and we need more context.
  • 4 Tests are still broken

This is mostly to get the ball rolling and to see if this fixes people's use cases around keyframes.

DanielJoyce avatar Jan 19 '24 04:01 DanielJoyce

Another option is to do only whitespace minification in TransformList::to_css, and don't try and change the types.

Ideally there should be a optional minification pass added, so to_css only deals with formatting.

parse -> [ minify ] -> to_css

DanielJoyce avatar Jan 19 '24 05:01 DanielJoyce

Another option would be to turn minify into an enum, expressing white_space only minification and white_space + transformation

DanielJoyce avatar Jan 21 '24 04:01 DanielJoyce

Closed by #694

devongovett avatar May 14 '24 04:05 devongovett