parca icon indicating copy to clipboard operation
parca copied to clipboard

Incorrect version in debug log

Open paulfantom opened this issue 3 years ago • 4 comments

I just noticed that running parca from ghcr.io/parca-dev/parca:v0.7.0 image with debug logs enabled can produce the following log message:

level=debug name=parca ts=2022-01-12T13:29:26.350057332Z caller=main.go:48 msg="parca initialized" version=dev commit=dev config="&{/var/parca/parca.yaml debug :7070 []  false 3h0m0s false simple 3 badgerinmemory}"

I would expect to see something like version=0.7.0 commit=3be8c676 in that line instead of version=dev commit=dev.

Side question - maybe it shouldn't be a debug log message? At least the part with version and commit sha.

paulfantom avatar Jan 12 '22 13:01 paulfantom

cc @metalmatze @fpuc

brancz avatar Jan 12 '22 14:01 brancz

That's been fixed along with #537

metalmatze avatar Jan 12 '22 14:01 metalmatze

Should we do a v0.7.1 release?

brancz avatar Jan 12 '22 14:01 brancz

I'll handle the release.

kakkoyun avatar Jan 13 '22 07:01 kakkoyun