parca icon indicating copy to clipboard operation
parca copied to clipboard

area/ui: Parca design refresh

Open yomete opened this issue 1 year ago • 5 comments

Note: PR #4959 should be looked at, reviewed, and merged in before taking a look at this PR. i.e. #4959 takes precedence over this.

Follow up: Implement new design for compare page

yomete avatar Jul 25 '24 11:07 yomete

🤖 Meticulous spotted visual differences in 640 of 680 screens tested: view and approve differences detected.

Last updated for commit bd1b96d. This comment will update as new commits are pushed.

alwaysmeticulous[bot] avatar Jul 25 '24 11:07 alwaysmeticulous[bot]

Three small things:

  1. I believe the original design had a horizontal line after the metrics graph, I feel like this was nice to separate the two sections.
  2. The iciclegraph still has a box around it, if anything, then I think the main visualization should be the thing that uses the most pixels possible.
  3. Perhaps this can be integrated in 1, but the original design also had a button for hiding the metrics graph. I feel like it would be nice to have this.

brancz avatar Aug 19 '24 09:08 brancz

May not be directly from this PR, but looks like the min-w on the sum-by input got lost, making it difficult to see the values easily.

Screenshot 2024-08-19 at 2 52 04 PM

manojVivek avatar Aug 19 '24 09:08 manojVivek

May not be directly from this PR, but looks like the min-w on the sum-by input got lost, making it difficult to see the values easily.

Screenshot 2024-08-19 at 2 52 04 PM

thanks for pointing out, will take a look at that.

yomete avatar Aug 19 '24 12:08 yomete

Three small things:

  1. I believe the original design had a horizontal line after the metrics graph, I feel like this was nice to separate the two sections.
  2. The iciclegraph still has a box around it, if anything, then I think the main visualization should be the thing that uses the most pixels possible.
  3. Perhaps this can be integrated in 1, but the original design also had a button for hiding the metrics graph. I feel like it would be nice to have this.

these are all good points. I'll make sure to implement them

yomete avatar Aug 19 '24 12:08 yomete