parca icon indicating copy to clipboard operation
parca copied to clipboard

*: filter profiling data using binary name

Open yomete opened this issue 10 months ago • 1 comments

This PR adds functionality to filter the icicle graph data by a binary. This was achieved in two parts:

  1. by adding a frameFilter parameter to the query request which is an array of strings so we can filter by one or many binaries.

  2. by implementing a new metadata call to fetch all mapping files (binary) attached to a query as well as other pprof labels. The new metadata call is implemented using a new REPORT_TYPE, REPORT_TYPE_PROFILE_METADATA on the query request. This was needed because if we filter the icicle graph data using the binary, after filtering we won't know the "total" set of binaries anymore, only those that we filtered by. But with this new call, we can always display all the binaries, irrespective of what it is being currently filtered by.

Additional things included:

  • We no longer add runtime functions as a binary.
  • The Runtime Filter dropdown (which was essentially a binary filter) has been removed in favor of this new filtering by binary implementation.

image

yomete avatar Apr 25 '24 16:04 yomete

🤖 Meticulous spotted visual differences in 259 of 435 screens tested: view and approve differences detected.

Last updated for commit 95e799a. This comment will update as new commits are pushed.

alwaysmeticulous[bot] avatar Apr 25 '24 16:04 alwaysmeticulous[bot]