parca icon indicating copy to clipboard operation
parca copied to clipboard

pkg/query: Return invalid argument if merging non-delta profiles with time range

Open metalmatze opened this issue 1 year ago • 2 comments

This shouldn't be allowed. In fact, our UI will never do such queries, it's just that the backend is still fine with this.

metalmatze avatar Jan 29 '24 15:01 metalmatze

✅ Meticulous spotted zero visual differences across 372 screens tested: view results.

Last updated for commit 04a9baa. This comment will update as new commits are pushed.

alwaysmeticulous[bot] avatar Jan 29 '24 15:01 alwaysmeticulous[bot]

Some tests fail with rpc error: code = InvalidArgument desc = merge queries with different timestamps are only supported for delta profiles. We should update these tests. I'll take a look.

metalmatze avatar Jan 30 '24 12:01 metalmatze

However, we don't want to enforce it at the API level. Closing.

metalmatze avatar Aug 01 '24 15:08 metalmatze