parca icon indicating copy to clipboard operation
parca copied to clipboard

Please remove long test files

Open GiedriusS opened this issue 2 years ago • 3 comments

In Grafana make run gives me:

        -> unzip /home/giedrius/go/pkg/mod/cache/download/github.com/parca-dev/parca/@v/v0.12.1.zip: mkdir /home/giedrius/go/pkg/mod/github.com/parca-dev/[email protected]/pkg/symbolizer/testdata/2d5745782d4
86738416336492d624458373872722f43476c446c45724d31434c692d6745383869752d2f5f6765757162714a666856504e464c73585830762f445a554f4e796c324b655554684d463241784b43: file name too long

Maybe the file names could be shorter? I actually can't even clone this repo :smile:

GiedriusS avatar Dec 14 '22 09:12 GiedriusS

Interesting. On what OS with what filesystem do you get this error? We actually use the build ID of the binary as a filename so renaming this would only be a temporary fix.

metalmatze avatar Dec 14 '22 10:12 metalmatze

It's probably possible to trigger this on any ecryptfs. I am running ecryptfs. See deficiencies list here. 2d5745782d4 86738416336492d624458373872722f43476c446c45724d31434c692d6745383869752d2f5f6765757162714a666856504e464c73585830762f445a554f4e796c324b655554684d463241784b43 is longer than 143 bytes.

GiedriusS avatar Dec 14 '22 11:12 GiedriusS

I think this could be an encoded build id, but I'm not sure, we need to check. If it's the case it'd be easier to fix.

kakkoyun avatar Dec 14 '22 12:12 kakkoyun