parca icon indicating copy to clipboard operation
parca copied to clipboard

Improve diff accessibility

Open brancz opened this issue 3 years ago • 3 comments

The color scheme used to connotate improvements or regressions uses green and red and blue for neutral. Unfortunately, those colors are not particularly accessible, and given that about 300 million people are colorblind we should make sure that at least a more accessible color palette is available or even used by default.

brancz avatar Jul 22 '22 12:07 brancz

I did some reading on this, and we can go with replace red/green scheme with yellow/blue scheme as that is colour-blindness friendly.

Here is an example in regard to GitHub PR diff:

Comparison between various vision anomaly:

Screenshot 2022-07-28 at 9 15 16 AM

Another option, instead of the red/green, we could go with magenta/green as that too gives good contrast (but doesn't retain the same perceived colour) for various types of vision anomaly.

Screenshot 2022-07-28 at 9 10 33 AM

Wdyt?

Also, should we make this scheme the default or make it switchable with a user preference option?

manojVivek avatar Jul 28 '22 03:07 manojVivek

I frankly don’t think I’m the right person to decide this, but if that’s what GitHub uses for diffs then I feel that’s probably a good choice.

brancz avatar Jul 28 '22 07:07 brancz

No, that is just something from a third-party GitHub theme modifier.

I'll do some more research, and then we can decide.

manojVivek avatar Jul 28 '22 07:07 manojVivek