parca icon indicating copy to clipboard operation
parca copied to clipboard

debuginfo: NewDebugInfodClientWithObjectStorageCache never reads back from bucket

Open kakkoyun opened this issue 3 years ago • 2 comments

We write to the bucket, however, we never read back. This cause probably multiple downloads to the bucket. https://github.com/parca-dev/parca/blob/12949775f8d7def1ce24fe44198b482c80aa507c/pkg/debuginfo/debuginfod.go#L88-L91

Moreover, we don't have any synchronization mechanism around this. I propose we upload directly to the debuginfo object store using metadata locking facilities.

kakkoyun avatar Jun 30 '22 05:06 kakkoyun

Whops nice catch. Yeah, I agree we should use the same synchronization techniques, and maybe more importantly, actually read from object storage if we have the debuginfos there already :D

brancz avatar Jun 30 '22 07:06 brancz

(sorry mistakenly closed the issue, reopened immediately)

brancz avatar Jun 30 '22 07:06 brancz